Merge pull request #14527 from akx/avoid-isfiles

Avoid unnecessary `isfile`/`exists` calls

1 files changed, 6 insertions, 5 deletions

diff --git a/modules/extensions.py b/modules/extensions.py
index 1899cd52..99e7ee60 100644
--- a/modules/extensions.py
+++ b/modules/extensions.py
@@ -32,11 +32,12 @@ class ExtensionMetadata:
         self.config = configparser.ConfigParser()

 

         filepath = os.path.join(path, self.filename)

-        if os.path.isfile(filepath):

-            try:

-                self.config.read(filepath)

-            except Exception:

-                errors.report(f"Error reading {self.filename} for extension {canonical_name}.", exc_info=True)

+        # `self.config.read()` will quietly swallow OSErrors (which FileNotFoundError is),

+        # so no need to check whether the file exists beforehand.

+        try:

+            self.config.read(filepath)

+        except Exception:

+            errors.report(f"Error reading {self.filename} for extension {canonical_name}.", exc_info=True)

 

         self.canonical_name = self.config.get("Extension", "Name", fallback=canonical_name)

         self.canonical_name = canonical_name.lower().strip()